This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug general/21001] Replacement of TEMP_FAILURE_RETRY is broken


https://sourceware.org/bugzilla/show_bug.cgi?id=21001

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |elfutils-devel at sourceware dot o
                   |                            |rg, mark at klomp dot org

--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
Removing the semi-colon looks correct. Sorry this wasn't tested properly.

The includes should always just be #include "system.h". No need to spell out
the path.

I don't know why we used to #define LIB_SYSTEM_H in libdwfl_crc32_file.c. The
change looks correct since there is nothing that should prevent system.h to get
included.

Could you submit a full patch, including ChangeLog entry and Signed-off-by
line, as spelled out in the CONTRIBUTING file and post it to
elfutils-devel@sourceware.org?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]