This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
[Bug 1001656] FreeBSD: add AF_PACKET socket familiy
- From: bugzilla-daemon at bugs dot ecos dot sourceware dot org
- To: ecos-patches at ecos dot sourceware dot org
- Date: Wed, 22 Jan 2014 07:46:12 +0000
- Subject: [Bug 1001656] FreeBSD: add AF_PACKET socket familiy
- Authentication-results: sourceware.org; auth=none
- Auto-submitted: auto-generated
- References: <bug-1001656-104 at http dot bugs dot ecos dot sourceware dot org/>
Please do not reply to this email, use the link below.
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001656
--- Comment #16 from Bernd Edlinger <bernd.edlinger@hotmail.de> ---
(In reply to comment #15)
> First, thanks for taking the time to find/fix all these bugs.
>
> I'd like to start working on getting these committed. After a
> preliminary look through the patches I have a few suggestions on how
> to more quickly get things committed.
>
> The patches contain hundreds diffs where nothing has changed but
> whitespace (usually at the end of the line):
>
OK, separating the white-space changes is easy I will do that.
> Splitting the changes up into smaller patches would also make it much
> easier. A separate patch for the AF_PACKET support and for each of
> the 10 bugs you listed would be ideal. That way somebody reviewing
> the code doesn't have to try to figure out which bug a particular
> change is addressing. It also means that the work of reviewing and
> committing the changes can be divided up among multiple maintainers.
>
Well, maybe I should start with writing a change-log.
I am not sure how to test each part of that patch separately.
But I will try to isolate obviously independent parts and
separate that where possible.
> Next is the question of copyright assignment. I'm not sure where the
> threshold is for "trivial" changes above which a copyright assignment
> is needed, and hopefully some other maintainers to comment on
> that. There's probably a good chance that for a contribution this
> large a copyright assignment will be needed.
>
The copyright-assignment was signed by
my company (softing.com) on 2012-10-25
and counter-signed by FSF on 2012-12-17
Bernd.
> --
> Grant
--
You are receiving this mail because:
You are on the CC list for the bug.