This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: [PATCH] cygwin: define PATH_MAX for host tools build
On 12/05/10 17:54, John Dallaway wrote:
> Spencer Oliver wrote:
>
>> On 12/05/2010 16:06, John Dallaway wrote:
>>> Hi Spencer
>>>
>>> Jonathan Larmour wrote:
>>>
>>>> Spencer Oliver wrote:
>>>>
>>>>> cygwin: define PATH_MAX for host tools build
>>>>
>>>> Wouldn't this be better in ecutils.cpp? It already has an ifdef
>>>> __CYGWIN__ block for cygwin_conv_to_*_path() which is the same place
>>>> PATH_MAX is used.
>>>
>>> I've been unable to find a build issue for which this patch might be
>>> required. Is there a specific eCos host tools source file which is
>>> failing to build for you? Can you provide the relevant part of your
>>> build log and the version of Cygwin that you are using please?
>>>
>>
>> using cygwin 1.7.1 gcc 4.4.3
>> issue is when building configtool
>
> It looks like this may be related to the gcc4 package. There are no
> build problems with gcc 3.4.4 and recent Cygwin. I will investigate...
FWIW he's clearly right that if you use PATH_MAX you should be
#include'ing <limits.h>.
Jifl
--
--["No sense being pessimistic, it wouldn't work anyway"]-- Opinions==mine