This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
This morning we discovered that ramfs started failing. There is something you don't run into every day... Could I have some comments on the attached patch? The problem is that it is illegal to cache pointers returned from findbuffer_node() across findbuffer_node() calls, due to reallocing happening, ANAICT. The patch closes a *tiny* window where the pointer can change. With longer filenames it is more likely that this can happen, but I suppose shorter filenames are not immune to these problems... Thanks to Laurentiu Cocanu(laurentiu.cocanu@zylin.com) for spotting this! He has a magic computer that happened to build a romfs image which was copied to ramfs where the order of the files just so happened to trigger this problem :-) -- Ãyvind Harboe Visit us at Embedded World, March 2nd-4th. IS2T's stand, HALL 10 - 118 http://www.zylin.com/events_embeddedworld.html US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer
Attachment:
fixramfs.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |