This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1000280] New port: Freescale MAC7100 Variant, Freescale ESCI serial driver


http://bugzilla.ecoscentric.com/show_bug.cgi?id=1000280





------- Additional Comments From ilijak@siva.com.mk  2006-05-30 16:05 -------
(In reply to comment #5)
> 
> I'm pritty sure that the header file will be placed into install/include without
> needing CYGPKG_IO_SERIAL_DEVICES == 1. There are some cases when you don't want
> the serial drivers, eg when building Redboot. If you can make it build without
> this that would be great.

It wont if its parent CYGPKG_IO_SERIAL_DEVICES is disabled (as it is by default
  - CYGPKG_IO_SERIAL_DEVICES == 0)
Anyway there is an ellegant solution. I created another package for the header,
CYGPKG_IO_SERIAL_FREESCALE_ESCI_H, not a child of CYGPKG_IO_SERIAL_DEVICES.
It is located at same direcotry with CYGPKG_IO_SERIAL_FREESCALE_ESCI only now we
have 2 cdl files.

> Ah, so does strh r1,[r0],#2 do an increment? When i first read the code it just
> looked like you were doing nops. So a comment would help explain what is going
> on for somebody who does not know the assembly language too well.
Done.

> 
> Calculated { "ROM" } is O.K. Please change the description to fit. 
Done

I'll do a little bit more testing and rewiev by myself and, if you don't have
additional remarks, I'd post a patch tomorrow.


-- 
Configure bugmail: http://bugzilla.ecoscentric.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]