This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hello, While compiling a redboot with -Wall -Werror for my target. Some warnings were raised. Here's a proposed patch for cleaning format warnings on redboot package (Impacted files redboot/current/src/iomem.c redboot//current/src/flash.c redboot//current/src/net/ping.c) /cvs-tempo/rsync/ecos-orig/packages is updated with the HEAD version of your CVS. ----------------------------------------------------------------- diff -u -p /cvs-tempo/rsync/ecos-orig/packages/redboot/current/src/iomem.c iomem.c --- /cvs-tempo/rsync/ecos-orig/packages/redboot/current/src/iomem.c 2005-06-27 15:14:32.000000000 +0200 +++ iomem.c 2005-06-27 15:19:43.000000000 +0200 @@ -157,15 +157,15 @@ do_iopeek(int argc, char *argv[]) switch (size) { case 4: HAL_READ_UINT32 ( base, value ); - diag_printf("0x%04x = 0x%08x\n", base, value ); + diag_printf("0x%04lx = 0x%08x\n", base, value ); break; case 2: HAL_READ_UINT16 ( base, value ); - diag_printf("0x%04x = 0x%04x\n", base, value ); + diag_printf("0x%04lx = 0x%04x\n", base, value ); break; case 1: HAL_READ_UINT8 ( base, value ); - diag_printf("0x%04x = 0x%02x\n", base, value ); + diag_printf("0x%04lx = 0x%02x\n", base, value ); break; } } ----------------------------------------------------------------- diff -u -p /cvs-tempo/rsync/ecos-orig/packages/redboot/current/src/flash.c flash.c --- /cvs-tempo/rsync/ecos-orig/packages/redboot/current/src/flash.c 2005-06-27 15:14:32.000000000 +0200 +++ flash.c 2005-06-27 15:19:43.000000000 +0200 @@ -534,7 +534,7 @@ fis_list(int argc, char *argv[]) if (image_found) { img = (struct fis_image_desc *) fis_work_block; img += image_indx; - diag_printf("%-16s 0x%08lX 0x%08lX 0x%08lX 0x%08lX\n", img->name, + diag_printf("%-16s 0x%08X 0x%08lX 0x%08lX 0x%08X\n", img->name, img->flash_base, #ifdef CYGSEM_REDBOOT_FIS_CRC_CHECK show_cksums ? img->file_cksum : img->mem_base, @@ -654,7 +654,7 @@ fis_free(int argc, char *argv[]) num_chunks = find_free(chunks); for (idx = 0; idx < num_chunks; idx++) { - diag_printf(" 0x%08lX .. 0x%08lX\n", chunks[idx].start, chunks[idx].end); + diag_printf(" 0x%08X .. 0x%08X\n", chunks[idx].start, chunks[idx].end); } #endif } @@ -851,8 +851,8 @@ fis_create(int argc, char *argv[]) // First, see if the image by this name has agreable properties if (img) { if (flash_addr_set && (img->flash_base != flash_addr)) { - diag_printf("Image found, but flash address (%p)\n" - " is incorrect (present image location %p)\n", + diag_printf("Image found, but flash address (%x)\n" + " is incorrect (present image location %x)\n", flash_addr, img->flash_base); return; ----------------------------------------------------------------- diff -u -p /cvs-tempo/rsync/ecos-orig/packages/redboot/current/src/net/ping.c net/ping.c --- /cvs-tempo/rsync/ecos-orig/packages/redboot/current/src/net/ping.c 2004-02-24 15:15:15.000000000 +0100 +++ net/ping.c 2005-06-27 17:08:47.000000000 +0200 @@ -232,7 +232,7 @@ do_ping(int argc, char *argv[]) if (icmp_received) { received++; if (verbose) { - diag_printf(" seq: %ld, time: %ld (ticks)\n", + diag_printf(" seq: %d, time: %ld (ticks)\n", ntohs(hold_hdr.seqnum), end_time-start_time); } } Hope this helps.
Attachment:
pgp00000.pgp
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |