This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
[PATCH] CYGIMP_KERNEL_SCHED_SORTED_QUEUES flaws.
- From: Sergei Organov <osv at topconrd dot ru>
- To: ecos-patches at sources dot redhat dot com
- Cc: ecos-discuss at sources dot redhat dot com, Andrew Lunn <andrew at lunn dot ch>
- Date: 14 Dec 2004 21:20:50 +0300
- Subject: [PATCH] CYGIMP_KERNEL_SCHED_SORTED_QUEUES flaws.
- References: <87llcjb3ts.fsf@osv.topcon.com>
Sergei Organov <osv@topconrd.ru> writes:
> For reference, here is the description:
>
> cdl_option CYGIMP_KERNEL_SCHED_SORTED_QUEUES {
> display "Dequeue oldest threads first"
> flavor bool
> default_value 0
> description "
> With this option enabled, threads queued in a thread queue
> will be dequeued in priority order, rather than last in,
> first out (LIFO). Threads of equal priority are dequeued
> oldest first. The only exception is the scheduler run
> queues where order is less important as each is already
> sorted by priority. Note that this makes the thread queueing
> less deterministic."
> }
>
>
> First, it seems that "display" should say something like "Dequeue
> highest priority threads first" to be consistent with the description
> and the meaning of the option.
>
> Second, the "... rather than last in, first out (LIFO)" seems to be
> just wrong. Shouldn't it be "... rather than first in, first out (FIFO)"
> instead?
Well, as nobody had commented, here is a patch that fixes it.
Index: packages/kernel/current/cdl/scheduler.cdl
===================================================================
RCS file: /cvs/ecos/ecos/packages/kernel/current/cdl/scheduler.cdl,v
retrieving revision 1.8
diff -a -u -r1.8 scheduler.cdl
--- packages/kernel/current/cdl/scheduler.cdl 24 Feb 2003 14:06:55 -0000 1.8
+++ packages/kernel/current/cdl/scheduler.cdl 14 Dec 2004 18:11:20 -0000
@@ -156,13 +156,13 @@
cdl_option CYGIMP_KERNEL_SCHED_SORTED_QUEUES {
- display "Dequeue oldest threads first"
+ display "Dequeue highest priority threads first"
flavor bool
default_value 0
description "
With this option enabled, threads queued in a thread queue
- will be dequeued in priority order, rather than last in,
- first out (LIFO). Threads of equal priority are dequeued
+ will be dequeued in priority order, rather than first in,
+ first out (FIFO). Threads of equal priority are dequeued
oldest first. The only exception is the scheduler run
queues where order is less important as each is already
sorted by priority. Note that this makes the thread queueing