This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
[Bug 1000096] new AT91 platform: JTST
- From: bugzilla at ecoscentric dot com
- To: ecos-patches at ecos dot sourceware dot org
- Date: Fri, 17 Sep 2004 16:23:47 +0100 (BST)
- Subject: [Bug 1000096] new AT91 platform: JTST
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000096
------- Additional Comments From andrew.lunn@ascom.ch 2004-17-09 16:23 -------
You missed one call to the macro _todo
+//
+// Diagnostic LEDs - there are three colored LEDs which can be used
+// to send a simple diagnostic value (8 bits)
+//
+
+// only 7 segments available
+void
+hal_at91_led(int val){
+ unsigned led=BIT21|BIT22|BIT23|BIT24|BIT25|BIT26|BIT27;
+
The comments don't agree with each other. I think the first comment should be
removed, but i don't have the hardware in front of me to see if it has a 7
segment display or 3 LEDS.
+// simple function to wait magic dsp task end
+void cyg_hal_wait_magic(){
+ cyg_uint32 stat;
+ do {
+ HAL_READ_UINT32(AT91_MAARCSE+AT91_MAARCSE_CMD, stat);
+ } while ((stat & AT91_MAARCSE_CMD_RUN));
+}
+// simple function to start magic dsp task
+void cyg_hal_run_magic(){
+ HAL_WRITE_UINT32(AT91_MAARCSE+AT91_MAARCSE_CMD,AT91_MAARCSE_CMD_RUN);
+}
There should be prototypes for these two function in plf_io.h.
Actually, im not sure they actually belong in the HAL. I think they more belong
in a package which provides an full API to the magic DSP.I would also expect a
more robust implementation, eg a timeout for incase the DSP is dead so that eCos
does not end up in an endless loop, any maybe calls to cyg_thread_delay(1) if
the kernel package is included so other threads get a chance to run.
Also in plf_io.h is a comment:
+//-----------------------------------------------------------------------------
+// end of plf_io.h
which is near the beginning of the file!
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.