This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: fatfs and io disk misc patches
- From: Andrew Lunn <andrew at lunn dot ch>
- To: Savin Zlobec <savin at elatec dot si>
- Cc: Andrew Lunn <andrew at lunn dot ch>, ecos-patches at sources dot redhat dot com
- Date: Thu, 1 Jul 2004 15:06:35 +0200
- Subject: Re: fatfs and io disk misc patches
- References: <40DA9B63.9000200@elatec.si> <20040629163314.GH5877@lunn.ch> <40E3DBF9.1060107@elatec.si> <20040701103046.GB11101@lunn.ch> <40E3F0FE.4070306@elatec.si>
> >I was talking about types, not variables:
> >
> >disk_callbacks_t, disk_channel, disk_funs all in disk.h
> >
> >
> I tried to follow the naming convensions used in io subsystem -
> like the io_serial : serial_callbacks_t, serial_channel, serial_funs, ...
> or io_eth : eth_drv_sc, eth_drv_funs, eth_hwr_funs, ...
OK, So its a widespread problem.....
I commited the patch.
> Index: devs/disk/synth/current/src/synthdisk.c
> ===================================================================
> RCS file: /cvs/ecos/ecos/packages/devs/disk/synth/current/src/synthdisk.c,v
> retrieving revision 1.1
> diff -u -5 -r1.1 synthdisk.c
> --- devs/disk/synth/current/src/synthdisk.c 19 Jan 2004 14:35:01 -0000 1.1
> +++ devs/disk/synth/current/src/synthdisk.c 1 Jul 2004 10:47:38 -0000
> @@ -121,14 +121,15 @@
> sectors_num: _spt_, \
> size: CYGNUM_IO_DISK_ECOSYNTH_DISK##_number_##_SIZE, \
> filefd: -1, \
> filename: CYGDAT_IO_DISK_ECOSYNTH_DISK##_number_##_FILENAME \
> }; \
> -static DISK_CHANNEL(synth_disk_channel##_number_, \
> - synth_disk_funs, \
> - synth_disk_info##_number_, \
> - _mbr_supp_ \
> +DISK_CHANNEL(synth_disk_channel##_number_, \
> + synth_disk_funs, \
> + synth_disk_info##_number_, \
> + _mbr_supp_, \
> + 4 \
> ); \
> BLOCK_DEVTAB_ENTRY(synth_disk_io##_number_, \
> CYGDAT_IO_DISK_ECOSYNTH_DISK##_number_##_NAME, \
> 0, \
> &cyg_io_disk_devio, \
The same needs applying to packages/dev/disk/v85x. Could you provide a
patch please?
Andrew