Re: JFFS2 : Node info mutex fix suggestion.

["Gary Thomas" <gary at mlbassoc dot com>]

Thomas Koeller said:
>  Gary Thomas wrote:
>> On Thu, 2004-02-12 at 09:19, Alf Nilsson wrote:
>> > When running a project with priority inheritance we noticed that all the
>> > threads that passed though JFFS did not return to their original
>> > priority. This due to the mutex count in the jffs2_inode_info was in
>> > some cases 2 as lowest. We found that this depended on a call to
>> > fs-ecos.c:jffs2_init_inode_info in fs-ecos.c:jffs2_new_inode. The 2nd
>> > call in fs-ecos.c:jffs2_new_inode that increases the mutex occurs in
>> > read.c:jffs2_do_new_inode.
>> > This might not be the ultimate solution, but it seemed like the right
>> > place to place the patch, but I'm open for suggestions.
>>
>> After consulting with David Woodhouse (the JFFS2 maintainer), I've
>> committed the following change(s).  Please let us know if you have
>> other problems.
>
> Unfortunatly, applying this change undid my previous change (1.24, applied by
> Andrew) and re-introduced the error it fixed. Can you please rectify this?
>

Can you elaborate what I broke?  I looked over the changes
and it's not obvious what needs to be changed.  If you send
patches against the latest sources, I'll put them in.

This is the problem when trying to reconcile two moving source
trees - one which we've changed locally and the one that David
has (and tests against)....

Thanks.


------------------------------------------------------------
Gary Thomas                 |
MLB Associates              |  Consulting for the
+1 (970) 229-1963           |    Embedded world
http://www.mlbassoc.com/    |
email: <gary@mlbassoc.com>  |
gpg: http://www.chez-thomas.org/gary/gpg_key.asc
------------------------------------------------------------