Re: Added unicast support to SNTP client

[Dan Jakubiec <djakubiec at yahoo dot com>]

I've attached an SNTP patch that addresses Andrew
Lunn's comments about my previous SNTP unicast
enhancements.  This patch includes:

1) SNTP documentation updates

2) SNTP test updates to include unicast mode testing

3) Support for extracting NTP server information from
DHCP

4) Removed NTP_UDP_PORT constant from sntp.h


Please note that this patch modifies the dhcp_prot.c
file.  There are other pending changes to this file
that were submitted to the patch list by Jay Foster. 
This patch does not include those (it is relative to
CVS as of Oct 15, 2003).

--
Dan Jakubiec
Systech Corporation


--- Andrew Lunn <andrew@lunn.ch> wrote:
> On Thu, Oct 02, 2003 at 03:41:00PM -0700, Dan
> Jakubiec wrote:
> > Hi Gary,
> > 
> > No problem: I've attached the same SNTP patch, but
> > this time using 'cvs diff -u'.
> 
> Index: packages/net/sntp/current/ChangeLog
>
===================================================================
> RCS file:
> /cvs/ecos/ecos-opt/net/net/sntp/current/ChangeLog,v
> retrieving revision 1.6
> diff -u -r1.6 ChangeLog
> --- packages/net/sntp/current/ChangeLog	21 May 2003
> 14:03:36 -0000	1.6
> +++ packages/net/sntp/current/ChangeLog	2 Oct 2003
> 22:36:41 -0000
> @@ -1,3 +1,9 @@
> +2003-09-29  Dan Jakubiec 
> <firstname.lastname@systech.com>
>                            
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> You need to set up emacs to fill in your email
> address correctly.
> This has also been committed to CVS!
> 
> +
> +	* src/sntp.c: Added support for SNTP unicast mode.
> +	* src/sntp.h: Added support for SNTP unicast mode.
> +	* src/sntp.cdl: Added support for SNTP unicast
> mode.
> +
>  2003-05-19  Andrew Lunn  <andrew.lunn@ascom.ch>
>  
> +/* General Definitions */
> +#define NTP_UDP_PORT            123
> +
> 
> I don't like this. Its not used anywhere in your
> code and you should
> be using getaddrinfo, or getservbyname. Both know
> about ntp.
> 
> Please could you also extend the test program. What
> i suggest it to
> extend the current test program so that after its
> finished the current
> test it sets the time back to the epoc and then
> sends a query to the
> server in the bootp record. After 20 seconds, sanity
> check the time in
> the same way the current test does.
> 
> Please could you also update the SGML documentation.
> 
> 
>        Thanks
>           Andrew

__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com

Attachment: sntp2.pat
Description: sntp2.pat