This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: NET/BSD_TCPIP: Fixed some compiler warnings


Gary Thomas <gary@mlbassoc.com> writes:

> n.b. I'm not trying to be picky, just watching what you're up to :-)
> 

I'm just picking the fluff of things so that we get clean builds in
the test farm. 


> > +SYSINIT(route, SI_SUB_PROTO_DOMAIN, SI_ORDER_THIRD, call_route_init, 0);
> 
> Couldn't you do this simpler by just fixing the signature for 
> 'route_init()'?  I don't see it being used anywhere else other
> than in this initialization.

I did that at first, and got a compile error since it has a
declaration in route.h. That made me think it was a public interface
and might be called from eleswhere. I'll admit I didn't actually go
check that. :-)

If you want to change it yourself, feel free, but it probably doen't
make much difference to code size.

-- 
Nick Garnett                    eCos Kernel Architect
http://www.ecoscentric.com      The eCos and RedBoot experts


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]