This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: V850 patches


Savin Zlobec wrote:
Hi,

I have attached some patches for v850 hal.
Here is what they do:

v850_p1.diff - adds a CYGNUM_HAL_V85X_INITIAL_STACK_SIZE cdl option
               for controlling the size of startup stack. Fixes the
               CYGSEM_HAL_NEC_INLINE_INTERRUPT_FUNCTIONS <->
               CYGSEM_HAL_V85X_INLINE_INTERRUPT_FUNCTIONS typo.

Fine.


v850_p2.diff - fixes the __skipinst function in v850_stub (the
               breakpoint inst on v850 is a "br *" and next_pc
               won't skip it) and adds the 2ram section in linker
               script.

Odd... this hasn't caused problems before, and I don't know of anything that would have changed between then and now.


v850_p3.diff - adds the hal_delay_us function and RedBoot hal options
               cdl component to ceb platform (I don't have the ceb platform
               so this patch is untested - but should work on any
               v850SA1/v850SB1 platform).

I think hal_delay_us should probably live in the v850 HAL, not the platform HAL, although you can surround it with #ifndef HAL_DELAY_US in var_intr.h so that plf_intr.h can have the option down the road to override it if it needs to.


NOTE: for RedBoot to work on ceb the size of reserved RAM should be
      increased in MLT RAM files.

Perhaps you could add a new MLT file set for RAM under RedBoot? It doesn't need a new startup type, it just needs a new option which CYGHWR_MEMORY_LAYOUT can depend on. While I'm concerned about the often limited memory sizes on this system, I also don't want the issue forgotten about :-).


Jifl
--
eCosCentric    http://www.eCosCentric.com/    The eCos and RedBoot experts
--[ "You can complain because roses have thorns, or you ]--
--[  can rejoice because thorns have roses." -Lincoln   ]-- Opinions==mine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]