Re: AT91EB55 and DataFlash

[Andrew Lunn <andrew dot lunn at ascom dot ch>]

On Thu, Feb 12, 2009 at 02:27:13PM +0000, Nick Garnett wrote:
> Andrew Lunn <andrew.lunn@ascom.ch> writes:
> 
> > On Thu, Feb 12, 2009 at 01:56:02PM +0100, Andrew Lunn wrote:
> > > On Thu, Feb 12, 2009 at 12:08:26PM +0000, John Dallaway wrote:
> > > > eCos maintainers
> > > > 
> > > > Building RedBoot for the AT91EB55 target (eb55) is currently failing due to:
> > > > 
> > > > a) CYGPKG_ERROR missing in the RedBoot .ecm files. It is required by
> > > > CYGPKG_DEVS_FLASH_ATMEL_DATAFLASH.
> > > 
> > > I think this is because of the inclusion of IO_SPI in all targets
> > > which have SPI. The dataflash CDL contains:
> > > 
> > > cdl_package CYGPKG_DEVS_FLASH_ATMEL_DATAFLASH {
> > >     display       "Atmel DataFlash parts support"
> > >     description   "Support for Atmel DataFlash"
> > >     active_if     CYGPKG_IO_SPI
> > >     requires      CYGPKG_ERROR    
> > > 
> > > I think just adding
> > > 
> > >     active_if     CYGPKG_IO_FLASH
> > 
> > Ah, not so easy afterall. From the Changelog:
> > 
> > 2005-06-29  Jani Monoses <ani@iv.ro>
> > 
> >         * include/dataflash.h: Allow the package to be compiled without
> >         io/flash. Return correct value from cyg_dataflash_get_page_count()
> > 
> > It looks like the requires statement is wrong, CYGPKG_ERROR is not
> > needed by dataflash. This fixes this problem, but it then explodes
> > later.
> > 
> > I think somebody from eCosCentric needs to look at this and compare
> > with there working code in their private branch.
> 
> All of the redboot ECM files for our boards with dataflash contain
> CYGPKG_ERROR. CYGPKG_DEVS_FLASH_ATMEL_DATAFLASH does not, but the AT91
> SPI driver needs it.

Yep, that was were it exploded. However, it should of been at
ecosconfig time it complained. The AT91 SPI driver is missing a
requires statement for CYGPKG_ERROR. I guess the error package should
be added to all targets which use the AT91 SPI driver.

   Andrew