This is the mail archive of the ecos-discuss@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Trying to figure out redboot TCP/IP stack


On Sun, 2004-09-19 at 03:41, Bob Koninckx wrote:
> Hi folks,
> 
> Just trying to understand, what's the reason for the call to
> MS_TICKS_DELAY in function __tcp_poll, since function __timer_poll
> already calls MS_TICKS_DELAY in a loop ?
> 
> void
> __tcp_poll(void) {
>   __enet_poll();
>   MS_TICKS_DELAY();
>   __timer_poll();
> }
> 
> Rewriting it as
> 
> void
> __tcp_poll(void) {
>   __enet_poll();
>   __timer_poll();
> }
> 
> apparently doesn't break anything and removes an unnecessary delay (and
> hence the risk for hardware overrun) from the code.

This may just be an oversight or bit-rot (timer_poll may have
changed over time, etc).  In any case, if it works fine, lets 
just make the change.  Care to send a patch?

Does it help with your CS8900 problems?

-- 
Gary Thomas <gary@mlbassoc.com>
MLB Associates


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]