This is the mail archive of the
ecos-discuss@sources.redhat.com
mailing list for the eCos project.
Re: Synchronization problem in IP stack
- To: Wade Jensen <Wade_Jensen at inter-tel dot com>
- Subject: Re: [ECOS] Synchronization problem in IP stack
- From: Jonathan Larmour <jlarmour at redhat dot com>
- Date: Wed, 12 Sep 2001 22:12:57 +0100
- Cc: ecos-discuss at sources dot redhat dot com, Hugo Tyson <hmt at redhat dot com>
- Organization: Red Hat UK Ltd.
- References: <07256AC5.00703FDB.00@chd-nt-mail01.inter-tel.com>
Wade Jensen wrote:
>
> 1. I noticed that there are many places in the IP stack that use #ifdef __ECOS
> or #ifdef __ECOS__, but the __ECOS__ label was not defined in the compiler
> options. Because of this, a call to sblock() was using the macro rather than
> the function call.
True. I think the better fix is to fix the places using __ECOS__ to use
__ECOS. I'll make it so.
> 2. The sblock() function was incorrectly assuming that sb_lock() unlocked the
> scheduler.
>
> 3. There was an unnecessary assertion in cyg_tsleep().
While I'm tempted to agree with you and just apply these bits of the patch,
I'll have to defer to Hugo, who has studied this part of the stack far more
than I.
Jifl
--
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine