Re: [ECOS] MS_TICKS() revisited

[Jonathan Larmour <jlarmour at redhat dot com>]

Grant Edwards wrote:
> 
> On Fri, Feb 09, 2001 at 07:50:04PM +0000, Jonathan Larmour wrote:
> 
> > Thanks for the patch. One query before I apply it:
> >
> > +#if !defined(CYGPKG_REDBOOT_NETWORKING)
> > +#define MS_TICKS_DELAY() hal_delay_us(1000)
> > +#endif
> > +
> >
> > Any reason this isn't do_ms_tick() ?
> 
> IIRC, I was thinking at the time that do_ms_tick() was part of
> the networking package.  It isn't, so it probably should be
> do_ms_tick().  Now that I think of it, it might be a better
> idea to move the definitions for MS_TICKS() and
> MS_TICKS_DELAY() from net.h into a more general spot like
> redboot.h.  Then we don't need that chunk at all.

I think that would be fine. If Gary T also agrees (CC'd) could you resubmit
your patch with that change?

Thanks!

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine