[Bug 1001606] Enable the cache on Kinetis in RAM startup mode

[bugzilla-daemon at bugs dot ecos dot sourceware dot org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001606

--- Comment #12 from Ilija Kocho <ilijak@siva.com.mk> 2012-06-18 22:16:14 BST ---
(In reply to comment #11)
> Hi Ilija,

I am extracting the discussion on FPU as topic in its own right, that might get
it's final shape in context of Cortex-M FPU support. The caches, on the other
hand have some options that need more detailed consideration.

> > >  - It appears that CYGHWR_HAL_CORTEXM_KINETIS_FPU is effectively redundant
> > > (since it's keyed off CYGHWR_HAL_CORTEXM_FPU), but I suspect this has now
> > > been dealt with in your recent patches.
> > 
> > It's actually Kinetis' specific. FPU is optional on Kinetis and it is
> > reflected in part names. If you toggle CYGHWR_HAL_CORTEXM_KINETIS_FPU in
> > configtool you'll notice changes in the part's name ('F' <-> 'D').
> > Optionally this option could be a data CDL with legal values "D" and "F"
> > (more consistent with other part name segments) but bool seems more natural
> > to me. Ref: The /part name building/ is described in SGML doc. 
> 
> Sure, but where CYGHWR_HAL_CORTEXM_KINETIS currently has:
>         calculated { "MK" . CYGHWR_HAL_CORTEXM_KINETIS_SUBFAM .
>             (CYGHWR_HAL_CORTEXM_KINETIS_FPU ? "F" : "D") .
>             (CYGHWR_HAL_CORTEXM_KINETIS_FLEXNVM ? "X" : "N") .
>             CYGHWR_HAL_CORTEXM_KINETIS_FLASH_NAME }
> you could just change that to:
>         calculated { "MK" . CYGHWR_HAL_CORTEXM_KINETIS_SUBFAM .
>             (CYGHWR_HAL_CORTEXM_FPU ? "F" : "D") .
>             (CYGHWR_HAL_CORTEXM_KINETIS_FLEXNVM ? "X" : "N") .
>             CYGHWR_HAL_CORTEXM_KINETIS_FLASH_NAME }
> 
> and preserve that behaviour? It seems better than have two options which
> effectively do exactly the same thing, and have to have the same setting as
> each other.
> 

I want to preserve also integral functionality of the part builder
CYGHWR_HAL_CORTEXM_KINETIS, including FPU option.
CYGHWR_HAL_CORTEXM_KINETIS_FPU selects FPU as Kinetis option and
CYGHWR_HAL_CORTEXM_FPU enables/disables FPU function so they aren't identical.
But it's true that they look alike so below is CYGHWR_HAL_CORTEXM_KINETIS_FPU
reshaped to resemble the other entries of the part builder
(CYGHWR_HAL_CORTEXM_KINETIS_FLEXNVM can be reshaped likewise).

        cdl_option CYGHWR_HAL_CORTEXM_KINETIS_FPU {
            display          "Floating Point Unit part name option"
            flavor           data
            no_define
            legal_values  { "D" "F" }
            default_value { "D" }
            requires      { CYGHWR_HAL_CORTEXM_FPU implies
                            CYGHWR_HAL_CORTEXM_KINETIS_FPU == "F" }
            description "Select/indicate whether the part has Floating Point
Unit. \"F\" - stands for 
            parts with FPU, while \"D\" for ones without."
        }

This form will distinguish CYGHWR_HAL_CORTEXM_KINETIS_FPU and
CYGHWR_HAL_CORTEXM_FPU in configtool and slightly simplify
CYGHWR_HAL_CORTEXM_KINETIS.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.