This is the mail archive of the ecos-bugs@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1001253] Kernel tests on small memory targets


Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001253

--- Comment #20 from Ilija Kocho <ilijak@siva.com.mk> 2011-07-05 15:43:55 BST ---
(In reply to comment #17)
> Ok, back to `tm_basic`
> 
> (In reply to comment #11)
> 
> > 1. tm_basic - is good as it is since 2 tasks as a minimum is a must
> > [for(i = 0;  i < 2;  i++) loops]. Number 2 is only enforced if the
> > macro NTEST_THREADS (now __NTEST_THREADS) calculates < 2. If memory is
> > too small than linker shall raise an error and that means that this
> > test can not be performed on that configuration.
> 
> Then it seems for me this will be more clear

To me both are obvious. I think it is not necessary explaining max to eCos
programmer :)

> 
> #ifndef max
> #define max(X,Y) ((X) > (Y) ? (X) : (Y))
> #endif
> 
> #define N_THREADS_MAX  ((CYGMEM_REGION_ram_SIZE/16)/CYG_THREAD_OVERHEAD)
> #define NTEST_THREADS  max(2, N_THREADS_MAX)

I would change N_THREADS_MAX to somethine other as upper expression suggests it
needn't be the Max. Maybe N_THREADS_EST (estimated) or N_THREADS_MAX_EST.

> 
> and it's all. I dislike to add that `NTEST_2_THR` (may be N_THREADS_MIN)
> and I've seen no sense to tweak those for loops. What do you think?

NTEST_2_THR was intended to mean constant 2. If you don't like it we can keep
the original (bare 2).

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]