Re: [PATCH] Honour errors when processing more than one file

[Jakub Jelinek <jakub@redhat.com>]

On Mon, Mar 04, 2019 at 05:49:26PM +0100, Tom de Vries wrote:
> 2019-03-04  Tom de Vries  <tdevries@suse.de>
> 
> 	PR dwz/24301
> 	* dwz.c (main): Handle dwz returning 1 if processing more than one file.
> 	* testsuite/dwz.tests/two-files-too-many-dies.sh: New test.

That looks wrong to me, that means once an error is reported for any single
one, the rest will not be processed.  That was not the intent and is
undesirable for the distro compression, we want to compress as much as
possible.

Guess that
          else if (resa[i - optind].res == 0)
            successcount++;
should be
          if (resa[i - optind].res == 0)
            successcount++;
	  else
	    ret = 1;
or something similar, I must say I don't really remember the difference
between res->res value and return value from dwz etc., but it seems weird
that if if some file isn't processed in normal mode and when switched into lowmem
mode succeeds, we don't count it as successcount, while if we already are in
lowmem mode from the previous file, we count it.

	Jakub