This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[toplevel, Cygwin] Don't warn if both newlib and winsup are missing


In July a patch was added to the Cygwin's toplevel that turns off newlib if winsup isn't also present.

In the review, a suggestion was made to warn when this was not the case and this was added and eventually committed.

The problem is when both cygwin and newlib are not present like when you build binutils or gcc under cygwin you now always get the warning. Though harmless, it annoys me.

So this simple patch suppresses that warning if there was no attempt to build newlib.

Tested in various combined trees using all four combinations with the following results:

a) newlib=no, winsup=no: No warning, neither built
b) newlib=yes, winsup=no: Warning, neither built
c) newlib=no, winsup=yes: No warning, winsup built
d) newlib=yes, winsup=yes: No warning, newlib and winsup built

There is no change in behaviour besides supressing the warning for case a).

OK to install?
Kelley Cook
(BTW no src cvswrite priv)

2004-10-12  Kelley Cook  <kcook@gcc.gnu.org>

	* configure.in (*-*-cygwin*): Supress warning when newlib not present.
	* configure: Regenerate.

*** ../gcc-orig/configure.in	Tue Oct  5 11:52:19 2004
--- configure.in	Tue Oct 12 12:08:02 2004
***************
*** 590,599 ****
      target_configdirs="$target_configdirs target-libtermcap target-winsup"
      noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}"
      # always build newlib if winsup directory is present.
!     if test -d "$srcdir/winsup"
!     then
        skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
!     else
        echo "Warning: winsup is missing so newlib can't be built."
      fi
  
--- 590,598 ----
      target_configdirs="$target_configdirs target-libtermcap target-winsup"
      noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}"
      # always build newlib if winsup directory is present.
!     if test -d "$srcdir/winsup"; then
        skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
!     elif test -d "$srcdir/newlib"; then
        echo "Warning: winsup is missing so newlib can't be built."
      fi
  

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]