Re: Pb with rxvt-2.7.10-3, libW11.dll (doubled KP_Subtract and KP_Add)

[Mark Blackburn <marklist at fangorn dot ca>]

gagou at softhome dot net wrote:

> Hi,
> I recently updated cygwin package rxvt from 2.7.9-4 to 2.7.10-3 and I 
> noticed that the "windows version" (out of X11) print 2 times the 
> chars KP_Subtract and KP_Add. The "X11 version" is OK.
> I've got this problem under w2k and xp.
> If I revert libW11.dll to the one included in 2.7.9-4, the problem 
> disapears.
> Did someone else noticed this ? (Is it a bug or a problem in my 
> configuration ?)
> Thanks,
> Gael.

I'm having this problem too. I'm running cygwin 1.3.22, rxvt-2.7.10-3, 
Windows 98.
I've found that by reverting some of the more recent patch in the CVS 
repository for rxvt the doubling of the KP Add/Subtract is fixed.

Patch is attached to show what I mean.



--- rxvt/W11/w32/event.c	2003-03-31 20:26:54.000000000 -0500
+++ rxvt-me/W11/w32/event.c	2003-04-07 18:30:24.000000000 -0400
@@ -123,10 +123,8 @@
 static void
 doTranslateMessage(MSG *m)
 {
-	if ((m->message == WM_KEYDOWN) && 
-	    ((m->wParam == VK_BACK) ||
-	     (((m->wParam == VK_ADD) || (m->wParam == VK_SUBTRACT)) &&
-	      (GetKeyState(VK_SHIFT) & 0x8000)))) return;
+	if ((m->message == WM_KEYDOWN) && (m->wParam == VK_BACK))
+		  return;
 	if ((m->message == WM_SYSKEYDOWN) && (m->wParam == VK_F10))
 	{
 	    m->message = WM_KEYDOWN;
@@ -315,8 +313,6 @@
                 case VK_F10:
                 case VK_F11:
 	        case VK_F12:
-	        case VK_ADD:
-	        case VK_SUBTRACT:
 		    QEvent(wineventq,window,message,wParam,lParam);
 		    break;
 		default:
@@ -574,8 +570,6 @@
                     case VK_F10:     key=XK_F10;         break;
                     case VK_F11:     key=XK_F11;         break;
                     case VK_F12:     key=XK_F12;         break;
-		    case VK_ADD:     key=XK_KP_Add;      break;
-		    case VK_SUBTRACT:key=XK_KP_Subtract; break;
 		    default:         key=0;              break;
 		}
 		if (key == 0) {

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/