This is the mail archive of the
cygwin-xfree@cygwin.com
mailing list for the Cygwin XFree86 project.
RE: xf86config patch
- From: Alexander Gottwald <alexander dot gottwald at informatik dot tu-chemnitz dot de>
- Cc: cygx <cygwin-xfree at cygwin dot com>
- Date: Tue, 9 Jul 2002 13:16:13 +0200 (CEST)
- Subject: RE: xf86config patch
On Mon, 8 Jul 2002, Harold Hunt wrote:
> Alexander,
>
> > > 1) In winconfig.c, why is this there:
> > >
> > > #ifndef PROJECTROOT
> > > #define PROJECTROOT "/usr/X11R6"
> > > #endif
> >
> > Hm, I just copied it from xf86Config.c. Just to be sure it's defined.
> >
>
> I added ``-DPROJECTROOT=$(PROJECTROOT)'' to DEFINES in hw/xwin/Imakefile and
seems to be ok.
> I put quotes (") around PROJECROOT in the call to xf86openConfigFile in
> winconfig.c. I then removed the PROJECTROOT define from winconfig.c. That
> seems to have worked quite well. Of course, I haven't tested it yet :)
you have changed function_name(PROJECTROOT) to function_name("PROJECTROOT")?
This will fail since the preprocessor won't substitute macros in strings.
Please use -DPROJECTROOT="\"$(PROJECTROOT)\"" and the unquoted PROJECTROOT
in the function call
> I need to you submit a diff for XWin.man, documenting the new parameters.
> I'll take care up updating the User's Guide when the time comes.
>
> I'm going to make a Server Test Series release that has your XF86Config
> patch as the only change. That way if we have problems we can track them to
> this patch, if necessary. I don't anticipate any problems, but I know that
> if I don't do a seperate release we will end up having problems and wishing
> that we had done a seperate release. :)
Ok,
bye
ago
--
Alexander.Gottwald@informatik.tu-chemnitz.de
http://www.gotti.org ICQ: 126018723