This is the mail archive of the cygwin-xfree@cygwin.com mailing list for the Cygwin XFree86 project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] RE: Ghost cursors (was: RE: alt-tab: client window receives tab / pressing both...)


Stuart,

Excellent.  I've applied this to Server Test Series - Test 58, which I have
just released.

I don't think it's necessary to change the logic in the WM_ACTIVATEAPP
message, cause we're going to want to reshow (on inactivation) the cursor
regardless of whether we are hiding when we are over an inactive
Cygwin/XFree86 window or not.  Failing to reshow could cause the cursor to
disappear for other Windows clients (by screwing up the cursor show/hide
count).

Actually... I just realized that we probably should change the current
behavior to *not* hide the Windows cursor when we receive a WM_ACTIVATEAPP
or WM_ACTIVATE message that tells us we are activating.  The reason for this
is that the user can be running a very small Cygwin/XFree86 window that is
far away from the taskbar and when they click on the Cygwin/XFree86 icon in
the taskbar we're going to hide the cursor, whereas the cursor has not yet
crossed (any may never cross) our window.  On the other hand, we always want
to show the cursor if we receive an inavtivation message.

I think I'm gonna go change that logic and stick it into Test 58 before
anyone downloads it.  :)  I like to be sneaky like that because it takes
about an hour to do all the release announcements, etc.

Harold

> -----Original Message-----
> From: cygwin-xfree-owner@cygwin.com
> [mailto:cygwin-xfree-owner@cygwin.com]On Behalf Of Stuart Adamson
> Sent: Wednesday, June 12, 2002 6:21 PM
> To: Cygwin XFree
> Subject: [PATCH] RE: Ghost cursors (was: RE: alt-tab: client window
> receives tab / pressing both...)
>
>
> Okay - attached is a patch which does this.  I've tested it with
> and without
> the
> -nodecoration flag (the windows mouse pointer still appears when
> you're over
> the
> windows title bar).  Added an entry to the man page as well.
>
> The magic command line argument is -hidewindowspointerwheninactive.
> Somebody might
> be able to come up with a slightly nicer name ;)
>
> In InitOutput.c I've initialized the ScreenInfo member for it to false as
> fFullScreen
> is also initialized to false - however I don't think either of these are
> needed as
> ZeroMemory() is called on the structure which should do this for us.
> Was this an oversight when adding fFullScreen or is it like this to aid
> readability?
>
>
> Stuart
>
> > -----Original Message-----
> > From: Harold Hunt [mailto:huntharo@msu.edu]
> > Sent: 12 June 2002 17:53
> > To: Cygwin XFree
> > Subject: Ghost cursors (was: RE: alt-tab: client window receives tab /
> > pressing both...)
> >
> >
> > > > (sort of ghost cursors).....
> > >
> > > You know - this never bothered me until you mentioned it -
> > now I keep
> > > seeing it and it's really annoying ;(  Are you / have you fixed this
> > > or shall I? (I'm currently running Test 57).
> >
> > However this gets fixed, just make sure that the behavior is
> > configurable
> > via a command-line parameter and have the default be the
> > current behavior.
> >
> > Harold
> >
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]