This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: console enhancements: mouse events etc


On Mar 30 17:46, Thomas Wolff wrote:
> Corinna Vinschen wrote:
> >>>Since you were looking into the Cygwin console code lately, maybe you
> >>>could find out why `stty sane' doesn't reset the character set?
> >>The tool to use would be 'reset'. So I'll try to find out why
> >>'reset' doesn't reset the character set :-\ .
> >>There are two methods to switch to the alternate character set. One
> >>is by just sending a Control-N. Most terminals "guard" this method
> >>by requiring an enable sequence before this works. I guess this
> >>would considerably reduce the risk that this happens, that's
> >>probably why they do it.
> >>I didn't implement the guarding mechanism in fhandler_console
> >>(although I prepared it somewhat) so I think I should fully
> >>implement that.
> The attached patch should make 'reset' work, and it should make the
> 'VT100 graphics garbage effect' less likely. Miraculously, even
> 'pstree -G' works now...

Cool, thanks for this patch.  How can I enforce printing garbage so I
can test the reset command?  My trick calling head -3 on the Fedora 11
ISO image doesn't work anymore.  Tcsh is always in a clean state
afterwards.  Obviously this is a good sign, but still...

> 2010-03-30  Thomas Wolff <towo@towo.net>
> 
>         * fhandler.h, fhandler_console.cc: Tune VT100 graphics mode
>           switching to follow ISO 2022 strictly.

One request.  Please look into the ChangeLog file and try to follow
more closely the layout of ChangeLog entries in the Cygwin ChangeLog
file.  For instance, we don't add multiple file or multiple functions
into the same line.  Sometimes a "throughout" is in order but usually
you should point to the changed function in parenthesis.

For now I'll just change the ChangeLog entry to:

  * fhandler (class dev_console): Drop vt100_graphics_mode_active.
  Add flags vt100_graphics_mode_G0, vt100_graphics_mode_G1 and
  iso_2022_G1.
  * fhandler_console.cc: Throughout, tune VT100 graphics mode switching
  to follow ISO 2022 strictly.

> diff -rup orig/fhandler.h ./fhandler.h

Hint:  Try `cvs diff -up'.  You don't have to have a clean copy
elsewhere.

Otherwise, the patch looks good.  I'm just wondering how I can test
reset as mentioned above.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]