This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: dup3/O_CLOEXEC/F_DUPFD_CLOEXEC, take 2


On Jan 14 11:54, Christopher Faylor wrote:
> On Thu, Jan 14, 2010 at 05:35:56PM +0100, Corinna Vinschen wrote:
> >Hi,
> >
> >here's the next iteration of the patch.  It takes the comments to the
> >first iteration into account, adds the pipe2 call, and uses O_CLOEXEC in
> >the POSIX IPC foo_open calls.  I also ran all three testcases provided
> >by Eric as well as a handcrafted test for open, which I created from the
> >pipe2 testcase.  All tests ran successfully.
> >
> >I'd appreciate another review.
> 
> Ship it!

Done.


Thanks for the review,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]