This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] --std=c89 error in sys/signal.h
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Tue, 29 Sep 2009 18:33:21 -0400
- Subject: Re: [PATCH] --std=c89 error in sys/signal.h
- References: <4AC2732D.5090304@users.sourceforge.net>
- Reply-to: cygwin-patches at cygwin dot com
On Tue, Sep 29, 2009 at 03:50:53PM -0500, Yaakov (Cygwin/X) wrote:
>Compiling a file which #include's <sys/signal.h> in C89 mode fails:
>
>$ echo "#include <sys/signal.h>" > test.c
>$ gcc -c test.c
>$ gcc -c -std=c89 test.c
>In file included from /usr/include/sys/signal.h:107,
> from test.c:1:
>/usr/include/cygwin/signal.h:74: error: expected
>specifier-qualifier-list before 'pthread_attr_t'
>/usr/include/cygwin/signal.h:80: error: expected
>specifier-qualifier-list before '__uint32_t'
>/usr/include/cygwin/signal.h:96: error: expected
>specifier-qualifier-list before 'pid_t'
>/usr/include/cygwin/signal.h:270: error: expected ')' before 'int'
>In file included from test.c:1:
>/usr/include/sys/signal.h:152: error: expected ')' before 'int'
>
>The problem is that both <cygwin/signal.h> and an #ifdef __CYGWIN__
>section of <sys/signal.h> need those typedefs from <sys/types.h>, but
>the latter is only #include'd #ifdef _POSIX_THREADS, which is off in C89
>mode.
>
>I see two possible solutions:
>
>1) Unconditionally #include <sys/types.h> in <sys/signal.h> (newlib), OR
>2) #include <sys/types.h> in <cygwin/signal.h>.
>
>Since this appears to be Cygwin specific, I went for the latter. Patch
>attached.
WDLD?
cgf