This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] getmntent()->mnt_type values that match Linux...


On Mon, Mar 19, 2007 at 02:30:16AM -0400, Ryan C. Gordon wrote:
>
>There was a discussion quite some time ago about getmntent()'s mnt_type 
>field:
>
>   http://www.cygwin.com/ml/cygwin-developers/2002-09/msg00078.html
>
>...but nothing seems to have come of it. I noticed that Cygwin builds of 
>PhysicsFS (http://icculus.org/physfs/) don't detect CD-ROM drives since 
>mnt_type is always "system" or "user" ... this patch changes this to 
>make an earnest effort to match what a GNU/Linux system would report, 
>and moves the system/user string to mnt_opts.
>
>Without some solution like this, code external to Cygwin would have to 
>take heroic measures (#ifdefs and calls into the Win32 API) to figure 
>out what type of filesystem /cygdrive/f really is.
>
>After patching, here's the output from "mount" for a hard drive with two 
>NTFS partitions (C: and D:), a CD-ROM drive (E:), a FAT memory stick 
>(F:), and a Samba share (Z:) ...
>
>$ mount
>C:\cygwin\bin on /usr/bin type ntfs (binmode,system)
>C:\cygwin\lib on /usr/lib type ntfs (binmode,system)
>C:\cygwin on / type ntfs (binmode,system)
>c: on /cygdrive/c type ntfs (binmode,noumount,system)
>d: on /cygdrive/d type ntfs (binmode,noumount,system)
>e: on /cygdrive/e type iso9660 (binmode,noumount,system)
>f: on /cygdrive/f type vfat (binmode,noumount,system)
>z: on /cygdrive/z type smbfs (binmode,noumount,system)
>
>
>I haven't noticed any side effects of this patch, but my testing of the 
>Cygwin system as a whole is fairly limited. Comments welcome.
>
>Patch is against latest CVS.

Unfortunately a patch of this size, which changes functionality will
require an assignment as discussed at http://cygwin.com/contrib.html .

Thanks for the patch and I hope you will be able/willing to send in
an assignment to Red Hat.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]