This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix cygrunsrv invocation in cygcheck


Brian Dessent wrote:

> > why not simply run "cygrunsrv --list --verbose" in verbose mode, instead
> > of actually going through one iteration of the loop?  Simply to reuse the
> > "copy output" code?  Brian?
> 
> The reason I did it that way is because if I had run "cygrunsrv --list

Now that I re-read what you said I think I misunderstood.  You're right,
it could have simply done

if(verbose)
  cygrunsrv --list --verbose
else
  foreach cygrunsrv --list
    cygrunsrv --query

And that would be somewhat more efficient.  But you're right, I did it
that way so that I wouldn't have to duplicate code between the two
cases... laziness.

Brian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]