This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to allow trailing dots on managed mounts


On Thu, Dec 16, 2004 at 09:23:56AM -0700, Mark Paulus wrote:
>Which is why I did what I did.  If you look, my patch allows for
>checking to see if "............................." was entered as an
>argument, and throws the exception if it was.  THEN, if that is not the
>case, it passes the FULL name to conv_to_win32_path to allow for proper
>demangling rules.

What you did was clear.  It was only a two line change, after all.

Unfortunately, you seemed to assume that all the work that cygwin went
through to figure out that trailing dot stuff was just useless and that
the rest of cygwin will work just fine with files containing trailing
dots regardless of whether the file is managed or not.  That is not the
case.  The point of the section of code that you patched was not just to
"throw the exception" it was to strip off the trailing dots.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]