This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Problems on accessing Windows network resources


Corinna Vinschen wrote:
> 
> Hi Pierre,
> 

> I've applied this patch.  I've just changed the code to use
> INVALID_HANDLE_VALUE instead of NULL throughout.
> 
> Thanks,
> Corinna
> 
Hi Corinna,

I was going to send you the modified patch tonight, with some extra
cleanup added.

After researching the issue, all cygwin routines I could find (not
only those ntsec related) initialize their handles to NULL, except
subauth() and create_token(). Those exceptions make sense because 
those two must return INVALID_HANDLE_VALUE on error.

The patch itself avoids initializing any handle (avoiding ambiguity), 
except the usual automatic initialization to 0 of the cygheap stuff.  

Do you want my patch anyway (reverting what you have just applied), 
or do we leave things as they are?

Pierre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]