This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: cygwin part of pseudo-relocs patch


On Tue, Sep 03, 2002 at 10:38:20AM +0400, egor duda wrote:
>This is an updated cygwin part of pseudo-relocs patch.  Relocations are
>performed inside of cygwin1.dll, as Chris suggested, and it seems to
>work ok in case of one dll referencing another one.  After new binutils
>package is released, it can go into cygwin release.

Sorry for the long delay in reviewing this.  As the mantra goes "I've
been incredibly busy".  I could tell you just how busy I am but I don't
have time right now.  Anyway, I thought that this patch would take some
time to review so I've been avoiding it.

As it turns out, it took very little time at all.

It seems to be ok, as far as I can tell, but I would prefer it if you
would use the cygwin_internal interface for adding new cygwin-specific
functionality.  That can allow a program to gracefully degrade when
a feature is not available rather than popping up an "entry point not
found" dialog.

Assuming that you agree to this change, feel free to check in a version
based on this concept.

Thanks and apologies again for the delay in reviewing this patch.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]