This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
RE: w32api compiler warning fix.
- To: "Danny Smith" <danny_r_smith_2001 at yahoo dot co dot nz>,"CP List" <Cygwin-Patches at Cygwin dot Com>
- Subject: RE: w32api compiler warning fix.
- From: "Robert Collins" <robert dot collins at itdomain dot com dot au>
- Date: Fri, 9 Nov 2001 10:04:52 +1100
- Cc: "Corinna Vinschen" <cygwin-patches at cygwin dot com>
> -----Original Message-----
> From: Danny Smith [mailto:danny_r_smith_2001@yahoo.co.nz]
>
>
> --- Earnie Boyd <earnie_boyd@yahoo.com> wrote: > Robert
> Collins wrote:
> >
> > I'm going to defer to Danny. I myself only agree with
> Corinna's argument
> > in that if it can be found to be documented that way then
> that's how it
> > should be coded.
> >
Ok. I'll revert the patch then sometime today. (ANyone else can feel
free to do so yourself, I've a broken machine to nurse to health before
I can do this).
>
>
> I think its "just" a preprocessor issue. This is how I would
Yup, it's purely a warning because of the way setup's main.cc was using
the definition.
> do it (Like
> the _TEXT macros):
> #define SECURITY_NULL_SID_AUTHORITY_VALUE {0,0,0,0,0,0}
> #define SECURITY_WORLD_SID_AUTHORITY_VALUE {0,0,0,0,0,1}
> #define SECURITY_LOCAL_SID_AUTHORITY_VALUE {0,0,0,0,0,2}
> #define SECURITY_CREATOR_SID_AUTHORITY_VALUE {0,0,0,0,0,3}
> #define SECURITY_NON_UNIQUE_AUTHORITY_VALUE {0,0,0,0,0,4}
>
> #define SECURITY_NULL_SID_AUTHORITY
> {SECURITY_NULL_SID_AUTHORITY_VALUE}
this is good, but unfortuntely the composite below now does not match
MS...
> #define SECURITY_WORLD_SID_AUTHORITY
> {SECURITY_WORLD_SID_AUTHORITY_VALUE}
...
however,
#define SECURITY_NULL_SID_AUTHORITY_VALUE 0,0,0,0,0,0
#define SECURITY_WORLD_SID_AUTHORITY
{SECURITY_WORLD_SID_AUTHORITY_VALUE}
would, but I don't see that gaining anything.
Rob