This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [Fwd: [PATCH] Setup.exe dialog boxes losing focus after download of ini/packages]
- To: cygwin-patches at cygwin dot com
- Subject: Re: [Fwd: [PATCH] Setup.exe dialog boxes losing focus after download of ini/packages]
- From: Christopher Faylor <cgf at redhat dot com>
- Date: Fri, 26 Oct 2001 10:50:42 -0400
- References: <3BD925A4.A0AE7BC6@syntrex.com>
- Reply-To: cygwin-patches at cygwin dot com
On Fri, Oct 26, 2001 at 10:58:12AM +0200, Pavel Tsekov wrote:
>
>
>-------- Original Message --------
>X-Mozilla-Status: 8001
>X-Mozilla-Status2: 00000000
>Message-ID: <3BD9241B.F6ABB110@syntrex.com>
>Date: Fri, 26 Oct 2001 10:51:39 +0200
>From: Pavel Tsekov <ptsekov@syntrex.com>
>X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.4.2-2 i686)
>X-Accept-Language: en
>MIME-Version: 1.0
>To: cygwin@cygwin.com
>CC: cygwin-patches@cygwin.com
>Subject: [PATCH] Setup.exe dialog boxes losing focus after download of
>ini/packages
>Content-Type:
>multipart/mixed;boundary="------------E92B406AC615E6FF9272C90C"
What's all of this ^^^?
>This patch removes the calls to SetForegroundWindow
>in geturl.cc and install.cc - these, IMO, make setup.exe
>dialogs to not properly gain focus after a the
>get_url_* or do_install dialogs are created. Actually
>there is no need to call SetForegroundWindow at all
>on these progress dialogs - they dont have to compete
>with anyone in the current app since only one dialog is
>active at any moment.
>
>Another way to fix the problem would be to add a
>SetForegroundWindow in the WM_INITDIALOG handler
>of each dialog of setup.exe.
>
>There are other 's too but since this is a very simple
>program I dont think its worth discussing.
ChangeLog?
cgf