This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: src/winsup/cygwin ChangeLog autoload.cc autolo ...
On Fri, May 04, 2001 at 11:01:48AM +0400, egor duda wrote:
>Hi!
>
>Thursday, 03 May, 2001 Christopher Faylor cgf@redhat.com wrote:
>
>>>>>>2001-05-03 Egor Duda <deo@logos-m.ru>
>>>>>>
>>>>>> * fhandler_socket.cc (set_connect_secret): Use /dev/random to
>>>>>> generate secret cookie.
>>>>>
>>>>>What happens to the buf that you allocate here? It looks like a memory
>>>>>leak.
>>>
>>>CF> Just to be a little clearer: It looks like a memory leak in execed proceses.
>>>CF> ccalloced memory is copied to execed processes.
>>>
>>>ok. take 2.
>
>CF> That looks better but I would prefer malloc/free rather than
>CF> malloc/delete.
>
>malloc/new/delete, not malloc/delete. delete assures that destructor
>(if any) is called for entropy_source.
Ok. You're right.
This looks ok. Please check it in.
cgf