Re: charset changes

[Andy Koppe <andy dot koppe at gmail dot com>]

Corinna Vinschen:
>> - With TIS-620 now being returned as the nl_langinfo name for the Thai
>> codepage CP874, I think it should also be recognised as a charset name
>> by setlocale(). A Google search shows that both th_TH.TIS620 and
>> th_TH.TIS-620 are in use, so perhaps best to add both. Shall I send a
>> newlib patch?
>
> No worries. ÂI'll add it to the Cygwin-only part of loadlocale.

Thanks.

>> - Not a new issue, but is there any point in accepting JIS as a
>> character set name, given that it isn't actually implemented?
>
> It's still supported by newlib itself. ÂWhat we could do is to disable
> it in loadlocale explicitely for Cygwin.

I think that would make sense.

>> And a complete nitpick: __set_charset_from_locale has lots of separate
>> calls to strcpy to set the charset. These could be consolidated by
>> assigning the charset name to a local variable and copying it in one
>> place.
>
> Sure, but in how far is that better or faster, given that this is
> a one-liner?

Should end up smaller, unless the compiler commonalises those calls
anyway. Never mind though; I'm just used to byte-pinching on embedded
systems.

Andy