On Feb 10 15:07, Yaakov (Cygwin/X) wrote:
When running rebase on multiple DLLs for x86, downwards rollover is
now going back to the top of the 64-bit address space, which isn't
right for x86 images. This patch should restore the previous
behaviour of rolling over (under?) to the top of the 32-bit space
instead. I didn't attempt to deal with upwards rollover due to the
following comment.
Thanks for catching. We should not rollover indiscriminately into the
upper two gigs either, though. It won't work for real 32 bit systems,
only for WOW64 systems.
But given that rebase is running on a specific machine, we could take
the WOW64-iness into account.
Also, rebase should not start at the upper bound, because it will
collide with PEB, TEB and shared-user-data anyway, see the output of
/proc/$PID/maps.
AFAICS, we should start at either 0xfffe0000 (WOW64) or 0x7f60000
(real 32 bit).
Does that make sense?