Re: [PATCH 0/2] Make setup -q -P work as expected

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

Hi Jon,

On Jul 22 14:22, Jon TURNEY wrote:
> I'm somewhat reluctant to mess with this code as it is rather convoluted, so these
> patches could probably use some careful review and/or testing.
> 
> But these patches attempt to make setup -q -P work more like the naive expectation [1]
> of just installing the specified package, rather than installing the specified package
> and upgrading all currently installed packages to the current version.
> 
> Note that setup -q -L -P [2] probably sill doesn't work as expected, I'm guessing
> that without the benefit of a setup.ini, all packages found in the local package dir
> are placed in one of the special categories 'Base' or 'Misc' and thus always installed.
> 
> [1] http://cygwin.com/ml/cygwin-xfree/2011-07/msg00041.html
> [2] http://cygwin.com/ml/cygwin/2011-07/msg00308.html
> 
> Jon TURNEY (2):
>   Push the implementation of defaultTrust() down from the PickView
>     class to packagedb class
>   When packages are selected on the command line in unattended mode,
>     just install those packages
> 
>  PickView.cc   |   28 ++++------------------------
>  choose.cc     |   30 ++++++++++++++++++++++++++++--
>  package_db.cc |   43 ++++++++++++++++++++++++++++++++++++++++++-
>  package_db.h  |    5 +++++
>  4 files changed, 79 insertions(+), 27 deletions(-)

are you planning to follow up on this?  If you're happy with your
changes, feel free to check them in, regardless of my comment.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat