Re: [PATCH] Multiple --site options

[szgyg <szgyg at ludens dot elte dot hu>]

On 7/22/2011 3:33 PM, Jon TURNEY wrote:
> On 30/05/2011 10:28, szgyg wrote:
> > I want to say `./setup.exe --site <ports> --site <local-repo>', so
> > there it is.
>
> However, I think it needs a clearer description: What it actually does is
> (i) add infrastructure for handling options which are repeated, and (ii)
> correctly handle multiple --site, --pubkey and -sexpr-pubkey options.

2011-07-25  SZAVAI Gyula <szgyg@ludens.elte.hu>

	* libgetopt++/src/StringArrayOption.cc: New file.
	Infrastructure for repeated string options.
	* libgetopt++/include/getopt++/StringArrayOption.h: Ditto.
	* libgetopt++/Makefile.am: Add new files.
	* site.cc (SiteSetting::SiteSetting): Handle multiple --site
	options.
	* crypto.cc (verify_ini_file_sig): Handle multiple --pubkey and
	--sexpr-pubkey options.
	* package_meta.cc (packagemeta::isManuallyWanted): Handle
	multiple --packages and --categories options.

> Would it make sense for the new StringArrayOption class derive from or
> have members of type StringOption, rather than duplicating some of it?

We can move some common code from {Bool,StringArray,String}Option up to 
the Option class. I will be AFK in the next two weeks, after that I will 
send a follow-up patch.

szgyg