This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] Move PrereqChecker.isMet() call out of ChooserPage::OnNext() to a separate stage


On 19/11/2010 15:17, Christopher Faylor wrote:
> On Fri, Nov 19, 2010 at 02:51:52PM +0000, Jon TURNEY wrote:
>> Move PrereqChecker.isMet() call out of ChooserPage::OnNext() to a separate stage,
>> so we can put the package chooser page away and indicate progress via the threebar
>> status page.
>>
>> 2010-11-19  Jon TURNEY  <jon.turney-GrJqePx9RPPAJUdA+FbntA@public.gmane.org>
>>
>> 	* choose.cc (OnNext): Remove PrereqChecker call, instead use new
>> 	WM_APP_PREREQ_CHECK state of Progress dialog.
>> 	* threebar.h (WM_APP_PREREQ_CHECK)
>> 	(WM_APP_PREREQ_CHECK_THREAD_COMPLETE): Add new messages.
>> 	* threebar.cc (OnActivate, OnMessageApp): Use single bar mode for
>> 	WM_APP_PREREQ_CHECK state.  Handle new messages.
>> 	* dialog.h (do_prereq_check_thread): Add prototype.
>> 	* prereq.cc (isMet, do_prereq_check_thread)
>> 	(do_prereq_check_reflector, do_prereq_check): Add progress reporting
>> 	during isMet, and thread containing moved PrereqChecker code.
> 
> Looks good.  Please apply.  
> 
> Thank you.

All three patches applied. I had to update the last one slightly to update it
for your PostMessageNow change of yesterday.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]