This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

cygutils: return statement missing in mkshortcut


Chuck,

Now that setup.exe reports postinstall errors to user, the issue with
mkshortcut reporting an error when there isn't one has become a bit
more serious. Could you do a cygutils respin with a fix?

Andy


Index: src/mkshortcut/mkshortcut.c
===================================================================
RCS file: /cvs/cygwin-apps/cygutils/src/mkshortcut/mkshortcut.c,v
retrieving revision 1.10
diff -u -r1.10 mkshortcut.c
--- src/mkshortcut/mkshortcut.c 3 Dec 2009 08:19:44 -0000       1.10
+++ src/mkshortcut/mkshortcut.c 11 Mar 2010 05:43:05 -0000
@@ -612,6 +612,7 @@
             }
           persist_file->lpVtbl->Release (persist_file);
           shell_link->lpVtbl->Release (shell_link);
+          return (0);
         }
       else
         {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]