This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: a2ps


Thanks Igor. I have fixed the typo in the readme and added the strip step.
The new files can be downloaded from:

http://mysite.verizon.net/res1xzsj/cygwin/a2ps-4.12-1.tar.bz2
http://mysite.verizon.net/res1xzsj/cygwin/a2ps-4.12-1-src.tar.bz2
http://mysite.verizon.net/res1xzsj/cygwin/setup.hint

Dave
                                            
 David Hudson | The Capital Group Companies 
     | Location: BRO | Extension: 51887     
      Outside: 714-672-1887 | E-mail:       
             dyyh@capgroup.com              
    [ Mailing: 135 S State College Blvd.    
         Brea, CA 92821-5704 USA ]          
                                            





                                                                                                                                                    
                    Igor Pechtchanski                                                                                                               
                    <pechtcha@cs.nyu.e       To:     David Hudson/INV/CG/CAPITAL@CG                                                                 
                    du>                      cc:     cygwin-apps@cygwin.com                                                                         
                    Sent by:                 Subject:     Re: a2ps (Was Re: [UPDATE] Pending package status (06 May 2003))                          
                    cygwin-apps-owner@                                                                                                              
                    cygwin.com                                                                                                                      
                                                                                                                                                    
                                                                                                                                                    
                    05/07/2003 02:01                                                                                                                
                    PM                                                                                                                              
                    Please respond to                                                                                                               
                    cygwin-apps                                                                                                                     
                                                                                                                                                    
                                                                                                                                                    




Yes.  Turns out I downloaded it, but got distracted by real work and
forgot to review it.  Sorry about that.

The CRLF issue and the permission bits were indeed fixed, in both the
binary and the source packages.

There's a minor typo in the readme:

  This will build, creat teh binary package and re-create the source
package.
                   ^^^^^^^^^
I'm still a bit wary of the "all" step in the build script, in that it
will remove the source directory, but that's my personal feeling, and
the consensus here seems to be to leave it the way it is...

However, your build script seems to be missing the "strip" step (compared
to, say, a similar script in cygutils).  FYI,

$ ls -l a2ps.exe
-rwx--x--x    1 igor     Administ   890050 Apr 16 12:19 a2ps.exe*
$ strip a2ps.exe
$ ls -l a2ps.exe
-rwx--x--x    1 igor     Administ   306688 May  7 16:56 a2ps.exe*

Otherwise this looks good.
           Igor

On Wed, 7 May 2003 David_Hudson@capgroup.com wrote:

> Hello,
>
> Both issues that were raised (CRLF and exec bits) had been rectified in
the
> final package posted on 4/16.
>
> Thanks
> Dave
>
> ------------------------
>
> On Wed, May 07, 2003 at 10:49:10AM -0400, Igor Pechtchanski wrote:
> >David,
> >
> >FYI, the two comments below are really addressed to the general
> >cygwin-apps audience, not you personally.
> >
> >Hmm, first off, the first link below (underlined) refers to aspell,
rather
> >than a2ps (Elfyn?).
> >
> >Secondly, I thought
> ><http://cygwin.com/ml/cygwin-apps/2003-04/msg00273.html> (the fourth
link)
> >was a review (at least, it was written as such).
> >If that's unacceptable, what constitutes a formal review?  Or do I
simply
> >need to update it for the latest posted release?
>
> That was certainly a formal enough review.  I didn't see any indication
> that your issues were rectified; at least not in that thread.  The CRLF
> issue, at least, deserves repackaging.
>
> cgf
>
> ----------------------------
> Hello all,
>
> I have uploaded the (hopefully) final version of the a2ps-4.12-1 package.
I
> used Max's suggestions on the build file to keep it as similar as
possible
> with the build file in the Package Guidelines.
>
> http://mysite.verizon.net/res1xzsj/cygwin/a2ps-4.12-1.tar.bz2
> http://mysite.verizon.net/res1xzsj/cygwin/a2ps-4.12-1-src.tar.bz2
> http://mysite.verizon.net/res1xzsj/cygwin/setup.hint
>
> Thanks for all the feedback on this process. I'll start looking at
> a2ps-4.13.
>
> Thanks
> Dave

--
                                          http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_                  pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_                   igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'                  Igor Pechtchanski
    '---''(_/--'  `-'\_) fL         a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Knowledge is an unending adventure at the edge of uncertainty.
  -- Leto II






Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]