This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Command line option to prevent MD5 verification


Robert Collins wrote:
> On Mon, 2003-04-07 at 08:40, Max Bowsher wrote:
>> Index: download.cc
>> ===================================================================
>> RCS file: /home/max/cvsmirror/cygwin-apps-cvs/setup/download.cc,v
>> retrieving revision 2.36
>> diff -u -p -u -p -r2.36 download.cc
>> --- download.cc 9 Mar 2003 01:28:52 -0000 2.36
>> +++ download.cc 6 Apr 2003 22:33:50 -0000
>> @@ -53,15 +53,18 @@ static const char *cvsid =
>>
>>  #include "Exception.h"
>>
>> +#include "getopt++/BoolOption.h"
>> +
>>  using namespace std;
>>
>>  extern ThreeBarProgressPage Progress;
>>
>> +static BoolOption NoMD5Option (false, '5', "no-md5", "Suppress MD5
checksum
>> verification");
>>
>>  bool
>>  validateCachedPackage (String const &fullname, packagesource &
pkgsource)
>>  {
>> -  if (pkgsource.md5.isSet())
>> +  if (pkgsource.md5.isSet() && !NoMD5Option)
>>      {
>>        // check the MD5 sum of the cached file here
>>        io_stream *thefile = io_stream::open (fullname, "rb");
>>
>>
>> Patch for setup-200303, as mentioned yesterday.
>
> ChangeLog? Thats twice you've skipped the changelog BTW.

More than that, I suspect, since it has become habit for me to type the
ChangeLog as part of my precommit checks.

I'll try to break the habit.

> Anyway, please changelog and apply to HEAD and setup-200303.

Done, regenerating snapshots.


Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]