This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP
- From: "Max Bowsher" <maxb at ukf dot net>
- To: "Gary R. Van Sickle" <g dot r dot vansickle at worldnet dot att dot net>,"Cygwin-Apps" <cygwin-apps at sources dot redhat dot com>
- Date: Sat, 5 Apr 2003 19:13:02 +0100
- Subject: Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP
- References: <NCBBIHCHBLCMLBLOBONKCEFGEAAA.g.r.vansickle@worldnet.att.net>
Gary R. Van Sickle wrote:
>> Robert Collins wrote:
>>> On Sat, 2003-04-05 at 19:23, Gary R. Van Sickle wrote:
>>>> 2003-04-05 Gary R. Van Sickle <g dot r dot vansickle at worldnet dot att dot net>
>>>>
>>>> * RECTPP.h: New file.
>>>
>>> Much better. A few remaining nits.
>>>
>>> a) The class name, as discussed before.
>>> b) RECTCC_H__F4098557_9A48_446d_AF28_2BE45D29F68D__INCLUDED_
>>> Uhm, thats plain ugly.
>
> It's a GUID, it's supposed to by ugly. Guaranteed to be unique, not
> going to collide with anything ever. That's how MS's "AppWizard" does
> it, and it seems like a good idea to me. Please Rob, if you're going to
> pick nits, pick on something that could possibly matter. For me? Please?
Gary, this doesn't matter much, but please no GUIDs.
I suggest you use _RECTPP_H_, as this follows the most common scheme in
setup.
Also, the file has DOS line endings. If convenient, please d2u it.
Otherwise, mention that the committer must d2u it when you resend.
Max.