Re: [PATCH] Filtering in FindVisitor

[Robert Collins <rbcollins at cygwin dot com>]

On Tue, 2003-03-18 at 05:23, Igor Pechtchanski wrote:
> This patch implements a FilterVisitor class that is a decorator on a
> FindVisitor and filters files according to the supplied Filter class (also
> implemented).  It also implements a particular filter, ExcludeNameFilter,
> that excludes any files with names matching a pattern.
> The two new files, FilterVisitor.cc and FilterVisitor.h, will have to be
> 'cvs add'ed.
> 	Igor
> ==============================================================================
> ChangeLog:
> 2003-03-17  Igor Pechtchanski <pechtcha at cs dot nyu dot edu>
> 
> 	* postinstall.cc (do_postinstall): Filter out '*.done'.
> 	* FilterVisitor.h: New header file.  Declare the
> 	FilterVisitor, Filter, and ExcludeNameFilter classes.
> 	* FilterVisitor.cc: New file.  Implement FilterVisitor,
> 	Filter, and ExcludeNameFilter.
> 	* Makefile.am: Add FilterVisitor.cc and FilterVisitor.h
> 	to inilint_SOURCES and setup_SOURCES.

Looks nice.

The strmatching logic should be a method of String++ IMO.
Also FilterVisitor isn't needed for inilint.

Cheers,
Rob
-- 
Robert Collins <rbcollins at cygwin dot com>

Attachment: signature.asc
Description: This is a digitally signed message part