This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fixed patch for install.cc


On Mon, 2003-03-10 at 09:09, Pavel Tsekov wrote:

> Changelog entry:
> 
> 2003-03-09  Pavel Tsekov  <ptsekov at gmx dot net>
> 
> 	* install.cc (do_install_thread): Use IDS_SKIP_PACKAGE 
> 	instead of IDS_CORRUPT_PACKAGE when asking the user to take
> 	action if the hash verification check fails for a source package.
> 	Do not increase the value of 'total_bytes' variable if the
> 	user chooses to skip over a package, which failed the hash
> 	verification.
> 
> 

Applied, thank you.
I made a small tweak to the code there at the same time, to eliminate
do_skip. It's good practice to use a query method where possible, as
this makes the semantic clearer to a casual reader (modulo the clarity
of the method names).

Rob
-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]