This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Request #2 to add a new package: ccdoc


Hi Pavel:

Thanks for taking the time to detail the issues. It really helps novices like
me:

Pavel Tsekov wrote:

> I've made a brief review of the packaging, but not the functionality. Here
> is a list of problems that need to be fixed:
>
> 1) The source package includes files/dirs left by tools like autoconf and
> configure. These need to be removed. I see there is no 'distclean' stage
> in you Makefile, so I guess the right place is in 'clean'.
>

I fixed this and added a distclean target.

>
> 2) Some of the files in the source package contain unix line endings,
> while others have dos line endings. All files should have unix line
> endings.
>

All sources files have unix line endings now.

>
> 3) The excutable file in the binary package should be stripped by running
> 'strip executable_file'.
>

The strip program is now run as part of the link target.

>
> 4) The man page in the binary pakage has a name of 'ccdoc.man'. Should
> be ccdoc.1. Seems like something is wrong with the 'install-man' stage
> in your Makefile.
>

The ccdoc.man name was changed to ccdoc.1

The install_man stage was fixed. It turned out to be a configure script
problem (default was /usr/local rather than /usr).

>
> 5) The source package should contain a dir called CYGWIN-PATCHES. This dir
> contains Cygwin specific files - like Cygwin specific README, setup.hint
> and other files. In the case of ccdoc it should contain setup.hint. Then
> you should generate a patch. To see how to generate this patch and what is
> its purpose visit the following link:
>
> http://cygwin.com/setup.html#srcpackage_contents
>

This CYGWIN-PATCHES subdirectory has been added.

The ccdoc-0.8.39-1.patch file has been added.

>
> Thanks!

You can find the updated package distribution files here:

    http://ccdoc.sourceforge.net/cygwin_tmp/ccdoc-0.8.39-1

Cheers,

Joe



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]