This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for postinstall not running


On Thu, May 16, 2002 at 07:30:52PM +1000, Robert Collins wrote:
>
>
>> -----Original Message-----
>> From: Christopher Faylor [mailto:cgf@redhat.com] 
>> Sent: Thursday, May 16, 2002 3:32 PM
>> To: cygwin-apps@cygwin.com
>> Subject: [PATCH] Fix for postinstall not running
>> 
>> 
>> Here is a fix for the problem of postinstall not running.
>> 
>> I'm not going to check this one into the trunk because it 
>> uses a static variable and "feels wrong" as a result.  I 
>> think we probably need to change the find interface, either 
>> to just return the relative path or the full path as needed.
>
>Hmm. I think we actually want to make it more oop. It should call into
>an object, not a 'find routine'. The passed in value will be the
>relative value, and the object gets to decide whether to prepend the
>path it called find with or not.

That's exactly what I was thinking.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]