This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
RE: Checked branch setup.exe changes into trunk
- From: "Robert Collins" <robert dot collins at itdomain dot com dot au>
- To: <cygwin-apps at cygwin dot com>
- Date: Wed, 15 May 2002 16:53:36 +1000
- Subject: RE: Checked branch setup.exe changes into trunk
> -----Original Message-----
> From: Christopher Faylor [mailto:cgf@redhat.com]
> Sent: Wednesday, May 15, 2002 1:05 PM
> To: cygwin-apps@cygwin.com
> Subject: Checked branch setup.exe changes into trunk
>
>
> It looks like all of the changes I made to the branch are
> applicable to the trunk as well.
>
> I know that there was some talk of using something to fix the
> strstr problem but I checked in my "fix" for that as well.
>
> While doing this, I noticed that a variation of the strstr
> problem still exists in one place. The check_ini() function
> can still match a trailing c:\foo\abcdefghijklmnopsetup.ini file.
>
> I don't know/remember enough about what is going on there to
> suggest a fix. Probably just checking for "\\setup.ini"
> would be adequate, though.
>
> I won't be crushed if any or all of my fixes are reverted but
> I thought I might as well check them in since AFAICT they
> were applicable on the trunk.
They won't be reverted (I recall asking you to check them in if you had
time). Thanks again.
Checking for \\setup.ini should be enough as long as / is never returned
by the find function. I'll do something like this in HEAD soon.
Rob