This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Re: setup crashing - fixed?
- From: "Michael A Chase" <mchase at ix dot netcom dot com>
- To: "Robert Collins" <robert dot collins at itdomain dot com dot au>,<cygwin-apps at sources dot redhat dot com>
- Date: Sat, 26 Jan 2002 22:49:09 -0800
- Subject: Re: setup crashing - fixed?
- References: <026501c1a6fd$95bc5910$0200a8c0@lifelesswks>
----- Original Message -----
From: "Robert Collins" <robert.collins@itdomain.com.au>
To: <cygwin-apps@sources.redhat.com>
Sent: Saturday, January 26, 2002 22:41
Subject: setup crashing - fixed?
> Right, I think I found the cause. At least I can successfully download
> from *every* available site, and before I had repeatable problems doing
> that.
>
> Corinna, can you CVS update and try a fresh build?
>
> I found a bug that could have caused the issue:
>
> site (char const *newkey)
> {
> key = new char[strlen (newkey + 1)];
> ^^^^^
> strcpy (key, newkey);
> };
>
> However, fixing that DID NOT fix the problem (although I had isolated
> the fault to this constructor by means of replacement new and new[]
> calls using HeapAlloc, combined with HeapValidate().)
>
> Moving the constructor body out of the header fixed the problem. I don't
> have time to generate a testcase, but if anyone does have time, I'm sure
> the gcc team would appreciate knowing about this. The fault occured when
> that constructor was called from a template instantiation of list.h.
I hope you moved the '+ 1' outside the strlen() as well.
--
Mac :})
** I normally forward private questions to the appropriate mail list. **
Give a hobbit a fish and he eats fish for a day.
Give a hobbit a ring and he eats fish for an age.